Skip to content

/ angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https link to editorconfig.org #27664

Closed
wants to merge 1 commit into from
Closed

https link to editorconfig.org #27664

wants to merge 1 commit into from
+1 −1

Conversation

@coliff
Copy link
Contributor

coliff commented Dec 14, 2018 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information
@googlebot googlebot added the cla: yes label Dec 14, 2018
@IgorMinar
IgorMinar approved these changes Dec 18, 2018
View changes
Copy link
Member

IgorMinar left a comment

thanks
@coliff @IgorMinar
build: use https link to editorconfig.org in .editorconfig
Loading status checks…
e40d9a9
@IgorMinar
Copy link
Member

IgorMinar commented Dec 18, 2018

Hi there! I fixed the commit message to follow our format and rebased this PR. Please help us process more PRs faster by fixing linting errors you get from CI in the future. thank you!
@ngbot ngbot bot added this to the needsTriage milestone Dec 18, 2018
mhevery added a commit that referenced this pull request Dec 18, 2018
@coliff @mhevery
build: use https link to editorconfig.org in .editorconfig (#27664)
Loading status checks…
9ab35a1 
PR Close #27664
@mhevery mhevery closed this in 8d0a3ce Dec 18, 2018
IgorMinar added a commit to IgorMinar/angular that referenced this pull request Dec 19, 2018
@coliff @IgorMinar
build: use https link to editorconfig.org in .editorconfig (angular#2…
f8c7e98 
…7664)

PR Close angular#27664
IgorMinar added a commit to IgorMinar/angular that referenced this pull request Dec 19, 2018
@coliff @IgorMinar
build: use https link to editorconfig.org in .editorconfig (angular#2…
23518c7 
…7664)

PR Close angular#27664
ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@coliff @ngfelixl
build: use https link to editorconfig.org in .editorconfig (angular#2…
edfe204 
…7664)

PR Close angular#27664
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar

Assignees
No one assigned
Labels
PR action: merge PR target: master & patch cla: yes comp: build & ci
Projects
None yet
Milestone
  needsTriage
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@coliff @IgorMinar @googlebot
You can’t perform that action at this time.