New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: import in-memory-web-api project #37182

Closed

crisbeto wants to merge 1 commit into angular:master from crisbeto:FW-2176/in-memory-web-api

Member

crisbeto commented May 18, 2020 •

edited

Moves the angular-in-memory-web-api project into the main repository in order to make it easier to maintain and release.

googlebot added the cla: yes label

crisbeto force-pushed the crisbeto:FW-2176/in-memory-web-api branch 16 times, most recently from 2599aa1 to bf5889e

crisbeto requested a review from IgorMinar

crisbeto marked this pull request as ready for review

crisbeto added PR action: review PR target: master & patch labels

kara added the comp: build & ci label

ngbot bot added this to the needsTriage milestone

crisbeto force-pushed the crisbeto:FW-2176/in-memory-web-api branch 2 times, most recently from 11be62a to 57345fc

IgorMinar requested changes

Member

IgorMinar left a comment

lgtm, except for two change requests

.pullapprove.yml Show resolved Hide resolved

packages/in-memory-web-api/BUILD.bazel Outdated Show resolved Hide resolved

IgorMinar added PR action: cleanup and removed PR action: review labels

crisbeto force-pushed the crisbeto:FW-2176/in-memory-web-api branch 2 times, most recently from 77025fb to 23ce79d

crisbeto force-pushed the crisbeto:FW-2176/in-memory-web-api branch 2 times, most recently from db62d00 to e57557f

crisbeto added PR action: review and removed PR action: cleanup labels

Member Author

crisbeto commented Jun 10, 2020

I've reorganized it based on the feedback @IgorMinar.

IgorMinar approved these changes

Member

IgorMinar left a comment

LGTM! Thank you!

Reviewed-for: global-approvers, code-ownership, dev-infra

Member

IgorMinar commented Jun 12, 2020

please rebase the PR one (last) time. thanks!

IgorMinar added PR action: merge and removed PR action: review labels

ngbot bot commented Jun 12, 2020

I see that you just added the PR action: merge label, but the following checks are still failing:
conflicts with base branch "master"
status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

IgorMinar added PR target: master-only and removed PR target: master & patch labels

crisbeto force-pushed the crisbeto:FW-2176/in-memory-web-api branch from e57557f to ac7c623


        build: import in-memory-web-api project

1264f58

Moves the `angular-in-memory-web-api` project into the main repository in order to make it easier to maintain and release.

crisbeto force-pushed the crisbeto:FW-2176/in-memory-web-api branch from ac7c623 to 1264f58

Member Author

crisbeto commented Jun 12, 2020

Rebased and resolved the CI issues.

Member

mhevery commented Jun 15, 2020

mhevery closed this in

87a679b

ngwattcos added a commit to ngwattcos/angular that referenced this pull request


        build: import in-memory-web-api project (angular#37182)

ed22728

Moves the `angular-in-memory-web-api` project into the main repository in order to make it easier to maintain and release.

PR Close angular#37182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.