Skip to content

bpo-40769: allow extra surrounding parentheses for invalid annotated assignment rule #20387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2020
Merged

bpo-40769: allow extra surrounding parentheses for invalid annotated assignment rule #20387

merged 1 commit into from
Jun 27, 2020

Conversation

isidentical
Copy link
Member

@isidentical isidentical commented May 25, 2020 •
edited by bedevere-bot
Loading

@isidentical isidentical requested a review from pablogsal as a code owner May 25, 2020 15:07
@isidentical isidentical requested a review from lysnikolaou May 25, 2020 15:08
lysnikolaou
lysnikolaou approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks. (You will probably need to regenerate parse.c)

lysnikolaou
lysnikolaou reviewed May 26, 2020
View reviewed changes
@lysnikolaou
Copy link
Member

@isidentical @pablogsal Friendly ping.

@isidentical
Copy link
Member Author

rebased to upstream

@isidentical
Copy link
Member Author

I've rebased again, CC: @pablogsal

@pablogsal pablogsal merged commit c8f29ad into python:master Jun 27, 2020
@pablogsal pablogsal added the needs backport to 3.9 only security fixes label Jun 27, 2020
@miss-islington
Copy link
Contributor

Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @isidentical and @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c8f29ad986f8274fc5fbf889bdd2a211878856b9 3.9

pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Jun 27, 2020
@isidentical @pablogsal
[3.9] bpo-40769: Allow extra surrounding parentheses for invalid anno…
d4c6e4f 
…tated assignment rule (pythonGH-20387).

(cherry picked from commit c8f29ad)

Co-authored-by: Batuhan Taskaya <batuhanosmantaskaya@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 27, 2020
@bedevere-bot
Copy link

GH-21186 is a backport of this pull request to the 3.9 branch.

pablogsal added a commit that referenced this pull request Jun 27, 2020
@pablogsal
[3.9] bpo-40769: Allow extra surrounding parentheses for invalid anno…
102ca52 
…tated assignment rule (GH-20387) (GH-21186)

(cherry picked from commit c8f29ad)
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@isidentical @fasihahmad
bpo-40769: Allow extra surrounding parentheses for invalid annotated …
fa06398 
…assignment rule (pythonGH-20387)
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@isidentical @arun-mani-j
bpo-40769: Allow extra surrounding parentheses for invalid annotated …
2b9cfac 
…assignment rule (pythonGH-20387)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@pablogsal pablogsal pablogsal approved these changes

Assignees

@pablogsal pablogsal

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@isidentical @lysnikolaou @miss-islington @bedevere-bot @pablogsal @the-knights-who-say-ni