[3.5] bpo-41004: Resolve hash collisions for IPv4Interface and IPv6In… #21233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, we only accept the security patch for 3.5-3.7. I close this PR cc @ericvsmith |
corona10
approved these changes
Jun 30, 2020
Since this issue is reported as the CVE-2020-14422.
I am okay to merge this PR as the security issue.
But waiting for @ned-deily and @ericvsmith 's comment :)
|
The decision whether to merge to 3.5 is up to the 3.5 release manager, @larryhastings. |
|
As I noted on the bpo issue, I think the NEWS blurb should be updated to include the CVE. |
…terface (pythonGH-21033) The __hash__() methods of classes IPv4Interface and IPv6Interface had issue of generating constant hash values of 32 and 128 respectively causing hash collisions. The fix uses the hash() function to generate hash values for the objects instead of XOR operation (cherry picked from commit b30ee26) Co-authored-by: Ravi Teja P <rvteja92@gmail.com> Signed-off-by: Tapas Kundu <tkundu@vmware.com>
|
@larryhastings Please help to review the backport to 3.5 of a security fix. Thanks! |
|
@larryhastings: Please replace |
|
Thanks for the backport! And, for the record, @ericvsmith is a great guy, but he is not nor has ever been a Python release manager. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
…terface (GH-21033)
The hash() methods of classes IPv4Interface and IPv6Interface had issue
of generating constant hash values of 32 and 128 respectively causing hash collisions.
The fix uses the hash() function to generate hash values for the objects
instead of XOR operation
(cherry picked from commit b30ee26)
Co-authored-by: Ravi Teja P rvteja92@gmail.com
Signed-off-by: Tapas Kundu tkundu@vmware.com
https://bugs.python.org/issue41004
The text was updated successfully, but these errors were encountered: