Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41100: Support macOS 11 when building #21113

Merged
merged 1 commit into from Jun 25, 2020

Conversation

@ronaldoussoren
Copy link
Contributor

@ronaldoussoren ronaldoussoren commented Jun 24, 2020

The description says it all: This PR is needed to build on macOS 11, because the release of Darwin is now 20.0.0, which doesn't match any of the Darwin cases used to disable _POSIX_C_SOURCE on macOS.

https://bugs.python.org/issue41100

@ronaldoussoren ronaldoussoren requested a review from ned-deily Jun 24, 2020
@corona10 corona10 changed the title BPO-41100: Support macOS 11 when building bpo-41100: Support macOS 11 when building Jun 24, 2020
@claui claui mentioned this pull request Jun 24, 2020
4 of 4 tasks complete
Copy link
Member

@ned-deily ned-deily left a comment

LGTM

@ned-deily ned-deily merged commit 8ea6353 into python:master Jun 25, 2020
10 checks passed
10 checks passed
Docs
Details
Check for source changes
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200624.19 succeeded
Details
bedevere/issue-number Issue number 41100 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 25, 2020

Thanks @ronaldoussoren for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this pull request Jun 25, 2020
(cherry picked from commit 8ea6353)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 25, 2020

GH-21153 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 25, 2020

GH-21154 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Jun 25, 2020
(cherry picked from commit 8ea6353)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jun 25, 2020
(cherry picked from commit 8ea6353)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 25, 2020

GH-21155 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jun 25, 2020
(cherry picked from commit 8ea6353)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
miss-islington added a commit that referenced this pull request Jun 25, 2020
(cherry picked from commit 8ea6353)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
ned-deily pushed a commit that referenced this pull request Jun 25, 2020
(cherry picked from commit 8ea6353)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants