Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API docs: is item "removed" or "deselected" ? #1485

Open
Pictor13 opened this issue May 6, 2019 · 0 comments
Open

API docs: is item "removed" or "deselected" ? #1485

Pictor13 opened this issue May 6, 2019 · 0 comments

Comments

@Pictor13
Copy link
Contributor

@Pictor13 Pictor13 commented May 6, 2019

The event documentation it says that item_remove is

Invoked when an item is deselected.

Explanation:

While from what I know the selection concept is about having a subset of (one or more) items in the state active.
So I understand "deselected" as not having any currently active item (e.g. when clicking outside of an item).
The item_remove looks like triggered when an item is removed (via remove-button plugin or backspace/canc).

Reasoning on terminology

It might be that the terminology overlaps because of having a Selectized control that allows to "select" values from a list, but where these selected items can be further "selected"/"activated" as a subset of the actual value selection.
The "activated" items will allow to remove a subset of the selected values altogether, while all the "selected" items will anyway be submitted as form-data value.

Question

Did I understood correctly or the documentation is actually right in using that terminology?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.