Error formatter new argument change not documented #1905

Timunas · 2019-09-10T16:47:21Z

Custom error formatter must have now 5 arguments instead of the old 4. These changes were introduced here on #1652

When migrating from 0.19 to 1.1.0 I had issues on a custom error formatter because the original_exception argument was introduced but that change was not documented on the upgrading guide.

dblock · 2019-09-11T14:22:20Z

Appreciate a PR to fix the docs, thanks.

myxoh · 2019-10-30T12:19:53Z

Given that we have this in the docs:

class Twitter::API < Grape::API
  error_formatter :txt, ->(message, backtrace, options, env, original_exception) {
    "error: #{message} from #{backtrace}"
  }
end

Would you say that is not enough?

dblock added the bug? label Sep 11, 2019

ruby-grape / grape

Error formatter new argument change not documented #1905

Error formatter new argument change not documented #1905

Timunas commented Sep 10, 2019

dblock commented Sep 11, 2019

myxoh commented Oct 30, 2019

ruby-grape / grape

Sponsor ruby-grape/grape

Join GitHub today

Error formatter new argument change not documented #1905

Error formatter new argument change not documented #1905

Comments

Timunas commented Sep 10, 2019

dblock commented Sep 11, 2019

myxoh commented Oct 30, 2019