Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Template Literals Example #2165

Open
wants to merge 4 commits into
base: master
from

Conversation

@MrDecipher
Copy link

@MrDecipher MrDecipher commented Jan 10, 2019

I wanted to use template literals in one of my projects but couldn't find an example. I saw #2044 and decided to add some examples to the README.md for others to find a quick examples if they desire to use template literals when using the module.

Readme.md Outdated Show resolved Hide resolved
@dougwilson dougwilson added the docs label Jan 15, 2019
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated
var first_name = "user provided first name value";
var last_name = "user provided last name value";
var query = `mysqk.format(INSERT INTO Users SET

This comment has been minimized.

@dougwilson

dougwilson Mar 8, 2019
Member

there is a typo here: mysqk should be mysql.

var first_name = "user provided first name value";
var last_name = "user provided last name value";
var query = `mysql.format(INSERT INTO Users SET

This comment has been minimized.

@dougwilson

dougwilson Apr 16, 2019
Member

Sorry I missed this on the last review. Was just going through trying to run the examples real quick. I think the quote on this line is in the wrong spot. I think it's supposed to be after the opening parentheses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.