New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to upgrade an old version of the cli #443
Comments
Currently, we are running this command in the extension to check for version:
What version was this subcommand introduced in? And before that, the A potential solution is that we can try the original command and if that fails, we can run Another possibility is that we assume that there are no external users still using this old version and we ignore this problem. @donokuda Can you post here what version you have? @hmakholm Are you planning on removing the |
Here's what
|
should work right from the earliest public release. The |
Thanks, both of you. I'd guess that we will have no external users with this version. And since the first public release had the subcommand, I don't think this is a problem we need to deal with. |
Reopening because I will put in a fix here. If we fail to run the version command for any reason, then we will return |
Describe the bug
When a user has an extremely old version of the cli, before the
codeql version
subcommand was implemented, there is an error when trying to check the version in the extension. Hence, the cli cannot be updated.To Reproduce
Install a really old version of the cli and then run
CodeQL: Check for CLI updates
. It will fail to run. (Not sure what cli version causes this.)Expected behavior
The CLI should be updated.
The text was updated successfully, but these errors were encountered: