Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance the ability of add #2178

Merged
merged 5 commits into from Jul 6, 2020
Merged

enhance the ability of add #2178

merged 5 commits into from Jul 6, 2020
+18 −10

Conversation

@wuyudi
Copy link
Contributor

wuyudi commented Jul 5, 2020

Describe your change:

enhance the ability of add

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@wuyudi
enhance the ability of add
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
975ef57
@TravisBuddy
Copy link

TravisBuddy commented Jul 5, 2020

Hey @wuyudi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 2d6d6e00-bef6-11ea-b6c3-5fc2c9c22d2c
@wuyudi
Update matrix_operation.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cee63b2
@cclauss
cclauss reviewed Jul 5, 2020
View changes
matrix/matrix_operation.py
matrix_a: List[list], matrix_b: List[list]) -> Tuple[list]:
shape = _shape(matrix_a)
Comment on lines +159 to 160

This comment has been minimized.

Sign in to view
Copy link
@cclauss

cclauss Jul 5, 2020

Member

Don't lines 159 and 160 need to have identical indentation?

This comment has been minimized.

Sign in to view
Copy link
@wuyudi

wuyudi Jul 6, 2020

Author Contributor

fixed.

This comment has been minimized.

Sign in to view
Copy link
@wuyudi

wuyudi Jul 6, 2020

Author Contributor

E125 continuation line with same indent as next logical line.

This comment has been minimized.

Sign in to view
Copy link
@cclauss

cclauss Jul 6, 2020

Member

Line 159
@wuyudi
Update matrix_operation.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5a892dc
@TravisBuddy
Copy link

TravisBuddy commented Jul 6, 2020

Hey @wuyudi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 03c43b00-bf42-11ea-8212-0f9c14daf924
@wuyudi
Update matrix_operation.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fc7da01
@cclauss
cclauss reviewed Jul 6, 2020
View changes
matrix/matrix_operation.py Outdated Show resolved Hide resolved
@wuyudi @cclauss
Update matrix/matrix_operation.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e57cf3c 
Co-authored-by: Christian Clauss <cclauss@me.com>
@cclauss
cclauss approved these changes Jul 6, 2020
View changes
@cclauss
Copy link
Member

cclauss commented Jul 6, 2020

This looks good to me... It would be helpful to get another reviewer.
@cclauss cclauss merged commit 367f8ce into TheAlgorithms:master Jul 6, 2020
2 checks passed
2 checks passed
codespell
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@wuyudi @TravisBuddy @cclauss
You can’t perform that action at this time.