Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: basket template rendering KeyError #3445

Closed
wants to merge 1 commit into from

Conversation

@catroll
Copy link

catroll commented Jul 7, 2020

saved_formset !!!
not save_formset
It seems I can't take it back, so... sorry

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #3445 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3445   +/-   ##
=======================================
  Coverage   85.10%   85.10%           
=======================================
  Files         289      289           
  Lines       15513    15515    +2     
=======================================
+ Hits        13202    13204    +2     
  Misses       2311     2311           
Impacted Files Coverage Δ
src/oscar/apps/basket/views.py 91.05% <100.00%> (+0.05%) ⬆️
@solarissmoke
Copy link
Member

solarissmoke commented Jul 7, 2020

Hi @catroll, could you please give us a bit more of an explanation of what the issue is that you are trying to fix here? I don't quite understand what you mean in the PR description.

@solarissmoke
Copy link
Member

solarissmoke commented Jul 17, 2020

I'm closing this due to lack of feedback on the query raised above - please feel free to reopen if you are able to provide some more input on what the issue is that this PR intends to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.