Skip to content

Update api_def_Ceil.pbtxt #37466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

rohanreddych
Copy link
Contributor

tensorflow/core/api_def/base_api/api_def_Ceil.pbtxt

@tensorflow-bot tensorflow-bot bot added the size:S CL Change Size: Small label Mar 10, 2020
@gbaned gbaned self-assigned this Mar 11, 2020
@gbaned gbaned requested a review from dan-zheng March 11, 2020 03:10
@gbaned gbaned added the awaiting review Pull request awaiting review label Mar 16, 2020
@gbaned gbaned requested a review from mihaimaruseac March 17, 2020 13:31
@mihaimaruseac
Copy link
Collaborator

Similar to #37605 and #37604, we need to first decide if doctests should go into the global API files instead of in Python ones.

@rohanreddych
Copy link
Contributor Author

@mihaimaruseac can you once check issue #25802 and the pull requests associated with it, they are updating the pbtxt's.

@mihaimaruseac
Copy link
Collaborator

Thank you for the link to that issue. It seems that only a few of the PRs from there are still in code as of now, most got reverted. Which gives more sense to me asking to wait on this for a decision about whether to include Python tests on general language API defs.

I will come back to all these PRs in a few days once a decision is taken and will guide on how to progress.

@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Mar 19, 2020
@gbaned gbaned added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Mar 24, 2020
@rohanreddych
Copy link
Contributor Author

@mihaimaruseac off topic doubt,if some thing is there in nightly version but not in stable when does it get included in stable version? I mean does it get included in the next TF release like 2.2.x?

@mihaimaruseac
Copy link
Collaborator

For stable releases it needs to be on master when the branch for the release gets cut. So it will go to TF 2.3 now.

@tensorflowbutler tensorflowbutler removed the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Mar 31, 2020
@gbaned gbaned added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes size:S CL Change Size: Small stat:awaiting tensorflower Status - Awaiting response from tensorflower
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants