Skip to content

/ framework

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from tslint to eslint #706

Closed
agubler opened this issue Mar 27, 2020 · 5 comments
Closed

Migrate from tslint to eslint #706

agubler opened this issue Mar 27, 2020 · 5 comments
Assignees
@bitpshr
Projects
Dojo 8

Comments

@agubler
Copy link
Member

@agubler agubler commented Mar 27, 2020

Enhancement

As tslint has been deprecated, we should move to using eslint.

Depends on a base configuration being added to @dojo/scripts, dojo/scripts#31
@agubler agubler changed the title Migrate from tslint to esline Migrate from tslint to eslint Mar 27, 2020
@bitpshr
Copy link
Member

@bitpshr bitpshr commented May 26, 2020

Happy to pick this up.
@bitpshr bitpshr self-assigned this May 26, 2020
@agubler
Copy link
Member Author

@agubler agubler commented May 26, 2020 •
edited

Awesome. I think @nicknisi raised a PR on dojo/scripts already that needs reviewing.
@nicknisi
Copy link
Member

@nicknisi nicknisi commented May 26, 2020

Yes I did! I tested against framework and there are a few issues minor issues in framework that I think should be fixed. I haven’t tested against widgets, though.
@nicknisi
Copy link
Member

@nicknisi nicknisi commented May 26, 2020

If you want to take this over, that’s totally cool with me, or I can continue.
@alyjon alyjon added this to To do in Dojo 8 via automation Jun 10, 2020
@agubler
Copy link
Member Author

@agubler agubler commented Jul 28, 2020

@bitpshr hey, where did you get to with this?
@alyjon alyjon moved this from To do to In progress in Dojo 8 Aug 12, 2020
@bitpshr bitpshr mentioned this issue Aug 18, 2020
Merged
3 of 3 tasks complete
@bitpshr bitpshr closed this in #826 Aug 18, 2020
Dojo 8 automation moved this from In progress to Done Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bitpshr bitpshr

Labels
None yet
Projects
Dojo 8
  
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

feat: switch from tslint to eslint
3 participants
@nicknisi @bitpshr @agubler
You can’t perform that action at this time.