Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] started adding django 2.1+ support #1434

Open
wants to merge 4 commits into
base: master
from
Open

Conversation

@auvipy
Copy link

@auvipy auvipy commented May 9, 2019

some packages like Django-pipeline lack Django 2.2 support. Will address them one by one.

Copy link
Member

@berkerpeksag berkerpeksag left a comment

We shouldn't upgrade from 2.0 to 2.2. The proper way to do this is upgrade to 2.1 first. And I'd suggest to create a some sort of plan before starting to work on this. For example, why django-pipeline doesn't work with Django 2.2? What's the action plan? Add Django 2.2 support to django-pipeline? Or use something else?

@auvipy
Copy link
Author

@auvipy auvipy commented May 9, 2019

@auvipy
Copy link
Author

@auvipy auvipy commented May 9, 2019

thanks for your input. Some of them are certainly valid. on the 2.0-2.1 upgrade, it's really not necessary as Django LTS to LTS upgrade is much easier than before. So I would like to stand on the ground of django 2.0 to 2.2 upgrade. definitely with proper plans and rigorous testing.

@auvipy
Copy link
Author

@auvipy auvipy commented May 9, 2019

django-pipeline is now on @jazzbrand/django-pipeline so I am free to contribute and release. Regarding using something else rather than django-pipeline I am open to looking for more options.

@berkerpeksag
Copy link
Member

@berkerpeksag berkerpeksag commented May 9, 2019

Sorry, I'm not going to merge a PR that attempts to upgrade Django from X to X+2 directly. Django release notes aren't cover all behavior changes, so it's much easier to detect regressions since the scope of the changes are much smaller between X and X+1.

@auvipy
Copy link
Author

@auvipy auvipy commented May 9, 2019

I am not accepting to get this PR merged anytime soon. As It's natural to complete many things which need to be addressed first. I can start another pr with X to X+1 upgrade. I do also want to experience your concerns are up to date.

@auvipy
Copy link
Author

@auvipy auvipy commented May 9, 2019

re_path or new simpler regex free URL paths which one do you prefer for this project?

@auvipy
Copy link
Author

@auvipy auvipy commented May 9, 2019

used both

@auvipy auvipy marked this pull request as ready for review May 9, 2019
@auvipy auvipy changed the title [WIP] started adding django 2.2 support [WIP] started adding django 2.1+ support May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.