Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
switch to github flavored markdown for CMS pages #1613
Merged
Conversation
|
Makes sense for this change. Thanks. |
|
Thank you for the review @Mariatta! |
| RENDERERS = deepcopy(DEFAULT_MARKUP_TYPES) | ||
| for i, renderer in enumerate(RENDERERS): | ||
| if renderer[0] == 'markdown': | ||
| markdown_index = i | ||
|
|
||
| RENDERERS[markdown_index] = ( | ||
| 'markdown', | ||
| cmarkgfm.github_flavored_markdown_to_html, | ||
| 'Markdown' | ||
| ) |
Comment on lines
+51
to
+60
di
Jul 14, 2020
Member
Suggested change
| RENDERERS = deepcopy(DEFAULT_MARKUP_TYPES) | |
| for i, renderer in enumerate(RENDERERS): | |
| if renderer[0] == 'markdown': | |
| markdown_index = i | |
| RENDERERS[markdown_index] = ( | |
| 'markdown', | |
| cmarkgfm.github_flavored_markdown_to_html, | |
| 'Markdown' | |
| ) | |
| RENDERERS = [ | |
| x, cmarkgfm.github_flavored_markdown_to_html if x == 'markdown' else xx, xxx, | |
| for x, xx, xxx in deepcopy(DEFAULT_MARKUP_TYPES) | |
| ] |
I don't know what to name these but maybe this would be more clear? idk
|
Approved regardless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
More and more becoming defacto which leads to confused users... rather than battle with extensions and the Markdown python module... just use
cmarkgfm.