Add the name of the env to RuntimeException #37538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
approved these changes
Jul 9, 2020
| @@ -79,7 +79,7 @@ public function getEnv(string $prefix, string $name, \Closure $getEnv) | |||
| } | |||
|
|
|||
| if (!isset($array[$key]) && !\array_key_exists($key, $array)) { | |||
| throw new EnvNotFoundException(sprintf('Key "%s" not found in %s (resolved from "%s").', $key, json_encode($array), $next)); | |||
| throw new EnvNotFoundException(sprintf('Key "%s" not found in "%s" (resolved from "%s").', $key, json_encode($array), $next)); | |||
There was a problem hiding this comment.
please revert his one, that's a false positive
There was a problem hiding this comment.
@nicolas-grekas fabbot.io told me so, but okay
There was a problem hiding this comment.
that's exactly what Nicolas said: it was a false positive of fabbot.io. The tool is not 100% perfect.
|
how do we move on with this? Is there anything else I need to do, or can you merge the pull request |
fabpot
approved these changes
Jul 31, 2020
|
Thank you @sFreezer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you have the name of the env in the exception message it is much easier to find the error
from -> symfony/dependency-injection#20