[Mailer] Updated README for the Mailer component #37542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jul 9, 2020
xabbuh
reviewed
Jul 9, 2020
wouterj
force-pushed
the
components/doc-mailer
branch
from
2c913d2 to
696560c
Compare
jt2k
reviewed
Jul 9, 2020
fabpot
requested changes
Jul 15, 2020
fabpot
approved these changes
Jul 31, 2020
|
Thank you @wouterj. |
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Aug 3, 2020
This PR was merged into the 4.4 branch. Discussion ---------- Removed Mailer component docs See symfony/symfony#37542 The component is quite easy to use in a standalone project. The example in the component's README will be enough I think (no need to confuse framework users by adding the examples in this doc). Meanwhile, I'm not sure what to do with the Mime component. Should we move it into a subguide (`/mailer/mime.rst`)? It doesn't really make sense to have it as a main guide I think. Commits ------- 225de94 Removed Mailer component docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's worth adding a second example showcasing the twig integration for 2 reasons:
symfony/twig-bridge, it won't be very easy to catch while reading the component code - unless you're very comfortable with the Symfony architecture.