[Validator] Add Isin validator constraint #37565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Jul 13, 2020
src/Symfony/Component/Validator/Tests/Constraints/IsinValidatorTest.php
Outdated
Show resolved
Hide resolved
derrabus
reviewed
Jul 13, 2020
src/Symfony/Component/Validator/Tests/Constraints/IsinValidatorTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Resources/translations/validators.fr.xlf
Outdated
Show resolved
Hide resolved
| // subtract from 10 | ||
| $rem = 10 - $mod; | ||
|
|
||
| // mod from 10 to catch if the result was 0 |
There was a problem hiding this comment.
I'm not sure these comments above add value, the code tells the same
There was a problem hiding this comment.
I remove some comments. WDYT now ?
VincentLanglet
force-pushed
the
isin
branch
2 times, most recently
from
a566236 to
e15cb19
Compare
fabpot
requested changes
Jul 31, 2020
| /** | ||
| * This method performs the Luhn algorithm to obtain a check digit. | ||
| */ | ||
| private function getCheckDigit(string $input): int |
There was a problem hiding this comment.
Instead, we should probably use the Luhn validator, that would avoid having 2 implementations of the same algo in code.
There was a problem hiding this comment.
Indeed. I made the changes. Is it ok the way I did @fabpot ?
Feature symfony#36362 typo Fix PR feedbacks Fix coding standard ticket 36362 fix PR feedbacks Update src/Symfony/Component/Validator/Constraints/IsinValidator.php Co-Authored-By: Yannis Foucher <33806646+YaFou@users.noreply.github.com>
nicolas-grekas
changed the title
fabpot
approved these changes
Aug 2, 2020
|
Thank you @VincentLanglet. |
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Aug 3, 2020
This PR was merged into the master branch. Discussion ---------- Add doc for Isin constraint Related to symfony/symfony#37565 Commits ------- 9b7bae9 Add doc for Isin constraint
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Yannis Foucher 33806646+YaFou@users.noreply.github.com
Rebase of #36368
I asked him by mail and he didn't have time to finish the PR and allowed me to do it.