[HttpClient] fix pausing AmpResponse #37578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nicolas-grekas
changed the title
kelunik
commented
Jul 22, 2020
|
@nicolas-grekas Tests for Amp's implementation pass, but |
nicolas-grekas
force-pushed
the
amp-pause-handler
branch
from
114fae0 to
f231495
Compare
nicolas-grekas
approved these changes
Aug 25, 2020
| @@ -348,6 +362,8 @@ private static function followRedirects(Request $originRequest, AmpClientState $ | |||
| $request->removeHeader('host'); | |||
| } | |||
|
|
|||
| yield $pause; | |||
There was a problem hiding this comment.
I moved to pause in this method.
kelunik
commented
Aug 25, 2020
| Loop::enable($id); | ||
| } | ||
| }); | ||
| $pause = $pauseDeferred->promise(); |
There was a problem hiding this comment.
@nicolas-grekas I guess this line should be below the following if, no?
There was a problem hiding this comment.
You wrote it this way, and I'm not sure it should be moved below. Can you please confirm?
nicolas-grekas
force-pushed
the
amp-pause-handler
branch
from
f231495 to
bf2d1cf
Compare
|
Thank you @kelunik. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the pause handler while streaming bodies in
AmpHttpClient.Needs to be rebased onto the target branch and needs some test fixes. @nicolas-grekas FYI.