Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mime] Fix EmailHeaderSame to make use of decoded value #37583

Merged
merged 1 commit into from Jul 23, 2020
Merged

[Mime] Fix EmailHeaderSame to make use of decoded value #37583

merged 1 commit into from Jul 23, 2020

Conversation

evertharmeling
Copy link
Contributor

@evertharmeling evertharmeling commented Jul 15, 2020

Fixes #35062

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #35062
License MIT

fabpot
fabpot approved these changes Jul 15, 2020
View changes
@evertharmeling
Copy link
Contributor Author

@evertharmeling evertharmeling commented Jul 15, 2020

Do I need to take a look at the failed test?

Looks like the hinted \Symfony\Component\Mime\Header\HeaderInterface (in \Symfony\Component\Mime\Header\Headers) does not have the getValue function.

But in the implementation the $header will be of type \Symfony\Component\Mime\Header\UnstructuredHeader which does...

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Jul 22, 2020
@nicolas-grekas nicolas-grekas changed the title Fix EmailHeaderSame to make use of decoded value [Mime] Fix EmailHeaderSame to make use of decoded value Jul 22, 2020
@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jul 22, 2020 •
edited

Yes please, tests should be green (at least the ones related to this change)

@evertharmeling evertharmeling force-pushed the patch-1 branch 3 times, most recently from cd73f52 to a26ee94 Compare Jul 22, 2020
@evertharmeling
Copy link
Contributor Author

@evertharmeling evertharmeling commented Jul 22, 2020

Test fixed, current fails are not PR related (Redis related)

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jul 23, 2020

Thank you @evertharmeling.

@nicolas-grekas nicolas-grekas merged commit df1a1ff into symfony:4.4 Jul 23, 2020
3 of 5 checks passed
This was referenced Jul 24, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@evertharmeling @nicolas-grekas @fabpot @carsonbot