Skip to content

Require PHPUnit 9.3 on PHP 8 #37595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2020
Merged

Require PHPUnit 9.3 on PHP 8 #37595

merged 1 commit into from
Jul 23, 2020

Conversation

GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented Jul 16, 2020 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
License MIT

The first version of PHPUnit to support PHP 8.0 is PHPUnit 9.3.

Depends on #37607. Related to composer/composer#9054.

@GrahamCampbell GrahamCampbell mentioned this pull request Jul 16, 2020
Merged
@GrahamCampbell GrahamCampbell marked this pull request as draft July 16, 2020 13:03
@GrahamCampbell GrahamCampbell changed the title Require phpunit 9.3 on PHP 8 Require PHPUnit 9.3 on PHP 8 Jul 16, 2020
@derrabus
Copy link
Member

Related: #37564

@nicolas-grekas
Copy link
Member

Thank you @GrahamCampbell.

@nicolas-grekas nicolas-grekas merged commit a0f7c88 into symfony:4.4 Jul 23, 2020
@GrahamCampbell GrahamCampbell deleted the patch-1 branch July 23, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seldaek Seldaek Seldaek left review comments

Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GrahamCampbell @derrabus @nicolas-grekas @Seldaek @carsonbot