Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Considers the possibility that _inputs_ has an equals sign after it. #2880

Open
wants to merge 1 commit into
base: master
from

Conversation

@jtrecenti
Copy link

@jtrecenti jtrecenti commented May 8, 2020

Currently, when using URL-based bookmarking, the URL is of the form url/?_inputs_&n=200, which is valid and legal but somewhat nonstandard because of the absence of an equals sign = after _inputs_.

Some applications add the equals sign by default, which breaks bookmarking. With this 2 character change, {shiny} would also work with url/?_inputs_=&n=200. Fixes #2576

@CLAassistant
Copy link

@CLAassistant CLAassistant commented May 8, 2020

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants