fix: remove corner mask override to increase window resize performance #24642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
reviewed
Jul 20, 2020
zcbenz
approved these changes
Jul 22, 2020
codebytere
approved these changes
Jul 22, 2020
|
Release Notes Persisted
|
This was referenced Jul 23, 2020
|
I have automatically backported this PR to "10-x-y", please check out #24701 |
|
I have automatically backported this PR to "9-x-y", please check out #24702 |
|
Would the corner fix be difficult to bring to Electron 8? |
|
/trop run |
|
@msavin The problem being solved by this PR does not exist in 8. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR addresses issue #23980 that has been around since electron 9.0.0, when the override of an internal method on NSWindow (to have smooth corners on a vibrant window), caused very bad/laggy resize performance for the whole window, even if vibrancy not applied.
Removing this produced still smooth corners on macOS 10.15.5, so probably it's already obsolete.
Checklist
Release Notes
Notes: fix: remove unnecessary corner mask overriding to increase window resize performance