New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement prefix function, knuth-morris-pratt another usage #2099

Merged

cclauss merged 5 commits into TheAlgorithms:master from nikalosa:prefix-function

Jun 17, 2020

Contributor

nikalosa commented Jun 12, 2020

Describe your change:

Prefix function implementation, another usage of knuth-morris-pratt algorithm

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized.
I know that pull requests will not be merged if they fail the automated tests.
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
All new Python files are placed inside an existing directory.
All filenames are in all lowercase characters with no spaces or dashes.
All functions and variable names follow Python naming conventions.
All function parameters and return values are annotated with Python type hints.
All functions have doctests that pass the automated testing.
All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

nikalosa and others added 2 commits


        Implement prefix function, knuth-morris-pratt another usage

57a3bfb


        fixup! Format Python code with psf/black push

135c458

TravisBuddy commented Jun 12, 2020

Hey @nikalosa,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

TravisBuddy Request Identifier: 021ced60-ac9b-11ea-8245-836d9da6cb4c

cclauss reviewed

strings/prefix_function.py Outdated

  
            2

            """

            prefix_result = prefix_function(input_str)

cclauss Jun 14, 2020

Member

Why create a variable only to throw it away on the next line?

nikalosa Jun 15, 2020

Author Contributor

I changed that, returning max value right away

nikalosa Jun 17, 2020

Author Contributor

Any more requirements for this code?

nikalosa and others added 3 commits


        Fix style

33a04c2


        updating DIRECTORY.md

84d9f3c


        Update prefix_function.py

c3c4957

cclauss approved these changes

cclauss merged commit 671e570 into TheAlgorithms:master

1 check passed

1 check passed

Travis CI - Pull Request Build Passed

Details

peRFectBeliever added a commit to peRFectBeliever/Python that referenced this pull request


        Implement prefix function, knuth-morris-pratt another usage (TheAlgor…

8a79bc5

…ithms#2099)

* Implement prefix function, knuth-morris-pratt another usage

* fixup! Format Python code with psf/black push

* Fix style

* updating DIRECTORY.md

* Update prefix_function.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.