Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] newly added search exponential search #470

Open
wants to merge 2 commits into
base: master
from

Conversation

@Yacha-Venkata-Rakesh
Copy link

Yacha-Venkata-Rakesh commented Oct 25, 2019

No description provided.

@ashwek
Copy link
Member

ashwek commented Nov 5, 2019

@Yacha-Venkata-Rakesh

for input,
size = 4
array = 77, 78, 79, 80
search element = 80
your program outputs Search Not Found

for input,
Size = 5
Array = 64, 65, 66, 67, 68
search element = 67
your program is stuck somewhere in an infinite loop & never exits

When a value is found in an array, prints its index also.

@ashwek ashwek added the bug label Nov 5, 2019
@kvedala
Copy link
Collaborator

kvedala commented Jul 21, 2020

@Yacha-Venkata-Rakesh any update on this ?

@Yacha-Venkata-Rakesh
Copy link
Author

Yacha-Venkata-Rakesh commented Jul 23, 2020

So sorry for delay I haven't noticed this. I'll try to fix the error by an hour. Thank you for letting me know about the bug.

@Yacha-Venkata-Rakesh
Copy link
Author

Yacha-Venkata-Rakesh commented Jul 23, 2020

I have updated the code. I hope there are no errors in it. Thanks @ashwek for describing the bug.
Thanks @kvedala reminding me about the issue.
Please let me know in case of any issues regarding code
Thank you.

@lgtm-com
Copy link

lgtm-com bot commented Jul 23, 2020

This pull request introduces 3 alerts when merging 2bc2b38 into 296f3d0 - view on LGTM.com

new alerts:

  • 2 for Expression has no effect
  • 1 for Missing return statement
@kvedala
Copy link
Collaborator

kvedala commented Jul 23, 2020

Thank you @Yacha-Venkata-Rakesh
Please note that the repo standards have been improved and automated. After every push to pull-request, a thorough check will inform you of any concerns.
After your latest push,

  1. LGTM has commented on the errors it has noticed
  2. the auto-checks have also reported errors. You can view them by clicking on the "details" link next to the error. here is the link for convenience and you can search for "error" to scroll to the error messages.

Please ensure that the CI tests pass without errors and that LGTM does not report any alerts. These concerns must be addressed before the PR can be merged.
Also, the documentation of the file is not to the standards. Please refer to other files in the repo like this one and update the code with respect to:

  1. documentation following doxygen protocol
  2. add self-test function and confirm the execution using assert function
@kvedala kvedala changed the title newly added search exponential search [feature] newly added search exponential search Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.