Skip to content

/ Javascript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Web-Programming (Open Weather Maps data fetch) #196

Merged
merged 2 commits into from Jun 21, 2020
Merged

Added Web-Programming (Open Weather Maps data fetch) #196

merged 2 commits into from Jun 21, 2020

Conversation

@ruppysuppy
Copy link
Contributor

ruppysuppy commented Jun 21, 2020 •
edited

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • Fixes: #187
@ruppysuppy
Added Web-Programming (Open Weather Maps data fetch)
Loading status checks…
31e0091
@itsvinayak
itsvinayak requested changes Jun 21, 2020
View changes
Web-Programming/OpenWeatherMaps.js
@@ -0,0 +1,31 @@
const fetch = require('node-fetch')

This comment has been minimized.

Sign in to view
Copy link
@itsvinayak

itsvinayak Jun 21, 2020

Member

what about this requirement,
we can add a common package.json file which can be used to install all requirements using
npm install

and please remove package-lock.json file
thank you @ruppysuppy

This comment has been minimized.

Sign in to view
Copy link
@itsvinayak

itsvinayak Jun 21, 2020

Member

and please add a global package.json file

This comment has been minimized.

Sign in to view
Copy link
@ruppysuppy

ruppysuppy Jun 21, 2020

Author Contributor

I have added a global package.json file and removed package-lock.json but the HeapSort was causing some issues, I didn't touch it but it was modified by itself.
@itsvinayak itsvinayak mentioned this pull request Jun 21, 2020
Merged
7 of 11 tasks complete
@itsvinayak
update
Loading status checks…
e78f710
@itsvinayak itsvinayak force-pushed the ruppysuppy:web-prog-owm branch from 6d5701b to e78f710 Jun 21, 2020
@itsvinayak itsvinayak merged commit 412995a into TheAlgorithms:master Jun 21, 2020
2 checks passed
2 checks passed
build (14.x)
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
@itsvinayak
Copy link
Member

itsvinayak commented Jun 21, 2020

nice work !!
@ruppysuppy
Copy link
Contributor Author

ruppysuppy commented Jun 22, 2020

Thanks a lot for helping me out with the branch issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsvinayak itsvinayak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Addition of Web Programming
2 participants
@ruppysuppy @itsvinayak
You can’t perform that action at this time.