Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove Mixins page #285
Open
Improve Mixins page #285
Conversation
State that: 1. Mixins are a __simple__ way to reuse component logic, rather than a flexible way to do it. The term __flexible__ goes into conflict with the last chapter of the page, which describes that mixins are in fact inflexible. 2. Add a section title for Precautions.
|
Thanks for this! Overall, agreed on the sentiment for the PR, just a small note on what to change. |
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ## Basics | |||
|
|
|||
| Mixins are a flexible way to distribute reusable functionalities for Vue components. A mixin object can contain any component options. When a component uses a mixin, all options in the mixin will be "mixed" into the component's own options. | |||
| Mixins are a simple way to distribute reusable functionalities for Vue components. A mixin object can contain any component options. When a component uses a mixin, all options in the mixin will be "mixed" into the component's own options. | |||
This comment has been minimized.
This comment has been minimized.
sdras
Jul 20, 2020
Member
This is a good point, however we avoid the use of words like "simple" as they can be hostile to people learning (see our writing guide for more info). It might be worth just taking out the qualifier altogether here.
This comment has been minimized.
This comment has been minimized.
CyberAP
Jul 20, 2020
Author
Contributor
Suggested change
| Mixins are a simple way to distribute reusable functionalities for Vue components. A mixin object can contain any component options. When a component uses a mixin, all options in the mixin will be "mixed" into the component's own options. | |
| Mixins distribute reusable functionalities for Vue components. A mixin object can contain any component options. When a component uses a mixin, all options in the mixin will be "mixed" into the component's own options. |
What do you think about this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
CyberAP commentedJul 20, 2020
State that:
Note
Thanks for your interest in submitting a PR! At this time, because the docs are in beta, the team is currently in the midst of changes and we are not ready for additional contributions yet.
To bring your issue to the team's attention though, we would recommend creating an issue and we'll get to it when we can.
Thanks for your understanding!