Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
feat: add support of arbitrary mounting point via attachTo option #1492
Conversation
|
I added in a message that I also didn't add any checks to see if both Also happy to help with any documentation updates that might be required. Please let me know. Thanks! |
This allows for users to specify where in the document their component should attach, either through a CSS selector string or a provided HTMLElement. This option is passed through directly to the vm.$mount method that is called as part of mount.js. This enables testing of SSR code with Vue test utils as well as rendering of applications via Vue test utiles in contexts that aren't 100% Vue fixes vuejs#1492
This allows for users to specify where in the document their component should attach, either through a CSS selector string or a provided HTMLElement. This option is passed through directly to the vm.$mount method that is called as part of mount.js. This enables testing of SSR code with Vue test utils as well as rendering of applications via Vue test utiles in contexts that aren't 100% Vue fixes vuejs#1492
|
Hi! Thanks for the PR. Seems reasonable. Happy to merge this... but can you please update the docs to include this? Otherwise no-one will be able to use this new feature! |
|
@jnields do you think you will have some time to update the docs by any chance? Going to do a 1.0 release pretty soon - would be good to get this in. |
This allows for users to specify where in the document their component should attach, either through a CSS selector string or a provided HTMLElement. This option is passed through directly to the vm.$mount method that is called as part of mount.js. This enables testing of SSR code with Vue test utils as well as rendering of applications via vue-test-utils in contexts that aren't entirely Vue fixes vuejs#1492
|
@lmiller1990 awesome, thank you! I pushed up some doc updates in English. |
This allows for users to specify where in the document their component should attach, either through a CSS selector string or a provided HTMLElement. This option is passed through directly to the vm.$mount method that is called as part of mount.js. This enables testing of SSR code with Vue test utils as well as rendering of applications via vue-test-utils in contexts that aren't entirely Vue fixes #1492
|
Looks good. This will go out with 1.0. We are finalizing the API. Aiming to have something out within a month. |
This allows for users to specify where in the document their component should attach, either through
a CSS selector string or a provided HTMLElement. This option is passed through directly to the
vm.$mount method that is called as part of mount.js
feat #1487
This enables testing of SSR code with Vue test utils as well as enables rendering of applications via Vue test utils in contexts that aren't 100% Vue
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: