Ensure the npm registry is used during "Publish" workflow #4286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unset the `npm_config_registry` env var which yarn overwrites to the yarn registry, which we don't want since the `.npmrc` file that gets created is configured to the npm registry.
TooTallNate
commented
May 7, 2020
TooTallNate
commented
May 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #4286 +/- ##
==========================================
+ Coverage 13.68% 14.60% +0.91%
==========================================
Files 294 294
Lines 10359 10482 +123
Branches 1351 1310 -41
==========================================
+ Hits 1418 1531 +113
- Misses 8844 8870 +26
+ Partials 97 81 -16
Continue to review full report at Codecov.
|
styfle
reviewed
May 7, 2020
styfle
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unset the
npm_config_registryenv var which yarn overwrites to theyarn registry, which we don't want since the
.npmrcfile that getscreated is configured to the npm registry.