Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix OpWorkflowModelLocalTest due to flaky XGBoost training #494
Conversation
TuanNguyen27
requested review from
gerashegalov,
Jauntbox,
leahmcguire,
tovbinm and
wsuchy
as
code owners
Codecov Report
@@ Coverage Diff @@
## master #494 +/- ##
==========================================
- Coverage 82.63% 78.83% -3.81%
==========================================
Files 345 345
Lines 11702 11702
Branches 388 388
==========================================
- Hits 9670 9225 -445
- Misses 2032 2477 +445
Continue to review full report at Codecov.
|
|
LGTM |
|
Add a description of flakiness, and how your fix addresses it |
|
LGTM |
…of the same class
TuanNguyen27
merged commit 7759915
into
master
5 of 6 checks passed
5 of 6 checks passed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Source of flakiness: default
BinaryClassificationModelSelector.withTrainValidationSplitsometimes makes the training set contain only positive or negative labels, which fails the training for xgboost.We address this flakiness by fixing the seed in the
DataSplitterforwithTrainValidationSplit, which will result in the same train-test split every time the test is run.