Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug with gcc 4.x #217

Open
wants to merge 2 commits into
base: master
from
Open

Fix a bug with gcc 4.x #217

wants to merge 2 commits into from

Conversation

@JloveU
Copy link

JloveU commented Oct 23, 2018

There is no std::put_time in gcc 4.x.
So I replaced it with std::strftime.

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #217 into master will increase coverage by 3.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   93.69%   97.32%   +3.62%     
==========================================
  Files          37       37              
  Lines         984     1084     +100     
  Branches       59        0      -59     
==========================================
+ Hits          922     1055     +133     
  Misses         29       29              
+ Partials       33        0      -33
Impacted Files Coverage Δ
lib/rpc/this_handler.cc 100% <0%> (ø) ⬆️
tests/testmain.cc 100% <0%> (ø) ⬆️
lib/rpc/this_server.cc 100% <0%> (ø) ⬆️
lib/rpc/this_session.cc 100% <0%> (ø) ⬆️
tests/rpc/this_session_test.cc 100% <0%> (ø) ⬆️
include/rpc/this_handler.inl 100% <0%> (ø) ⬆️
include/rpc/dispatcher.inl 100% <0%> (ø) ⬆️
tests/rpc/response_test.cc 100% <0%> (ø) ⬆️
tests/rpc/server_session_test.cc 100% <0%> (ø) ⬆️
tests/rpc/dispatcher_test.cc 99.13% <0%> (+0.15%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b00c4c...ceed1c9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.