Skip to content

[issue-4822] - merge() doesn't throw any Error when object is frozen #4824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[issue-4822] - merge() doesn't throw any Error when object is frozen #4824

wants to merge 1 commit into from

Conversation

gagyibenedek
Copy link

@gagyibenedek gagyibenedek commented Jun 19, 2020 •
edited
Loading

Fix for #4824.
Added extra check to make sure an error is thrown.
Added a test case too and run it manually (since npm test is broken).

@gagyibenedek
[issue-4822] - merge() doesn't throw any Error when source object is …
b061f61 
…frozen

Added extra check to make sure an error is thrown.
@jsf-clabot
Copy link

jsf-clabot commented Jun 19, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Doatti
Copy link

Doatti commented Jun 28, 2020

You tagged this PR instead of the issue. The correct issue number is #4822.

@Doatti
Copy link

Doatti commented Jun 28, 2020

Maybe the isFrozen check should be added to the internal createAssigner function instead merge. That would fix the same issue with functions like _.assign, _.assignIn etc.

@mhombach
Copy link

@gagyibenedek Are you still working on this? :)

@bnjmnt4n
Copy link
Contributor

See #4822 (comment).

@bnjmnt4n bnjmnt4n closed this Dec 21, 2020
@jdalton jdalton added issue bankruptcy Closing the issue/PR to start fresh and removed issue bankruptcy Closing the issue/PR to start fresh labels Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
change wontfix
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gagyibenedek @jsf-clabot @Doatti @mhombach @bnjmnt4n @jdalton