Skip to content

/ C-Sharp-Algorithms

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 46: Switch netcoreapp2 to netstandard2 for libraries. … #133

Open
wants to merge 1 commit into
base: master
from
Open

Issue 46: Switch netcoreapp2 to netstandard2 for libraries. … #133

wants to merge 1 commit into from

Conversation

@RyanGrange
Copy link
Contributor

@RyanGrange RyanGrange commented Apr 25, 2020

Description

Update for issue 46:
Switch netcoreapp2 to netstandard2 for libraries.
Removed unused using that would have required netcoreapp3.1 to compile.
Fixed string to char because netstd2 didn't allow for strings as char arrays.
Added .NETStandard2.0 dependency to nuspec.

Checklist

  • An issue was first created before opening this pull request
  • The new code follows the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to ensure that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
@RyanGrange
Issue 46: Switch netcoreapp2 to netstandard2 for libraries. Removed u…
Loading status checks…
3045910 
…nused using that required netcoreapp3.1. Fixed string to char. Added .NETStandard2.0 dependency to nuspec.
@RyanGrange RyanGrange mentioned this pull request Apr 25, 2020
Open
@aalhour
Copy link
Owner

@aalhour aalhour commented May 27, 2020

Hi @RyanGrange, which operating systems did you test this change on?
@aalhour aalhour requested a review from PatrykOlejniczak May 27, 2020
@aalhour aalhour added this to In progress in Kanban Board via automation May 27, 2020
@aalhour aalhour linked an issue that may be closed by this pull request May 27, 2020
.NetStandard and nuget #46
Open
Kanban Board automation moved this from In progress to Reviewer approved Jun 7, 2020
@PatrykOlejniczak
PatrykOlejniczak approved these changes Jun 7, 2020
View changes
Copy link
Collaborator

@PatrykOlejniczak PatrykOlejniczak left a comment •
edited

I apologize for the late check.

NetStandard is best option for us, because we shouldn't use any specific API.

I checked that on Windows 10, LGTM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrykOlejniczak PatrykOlejniczak

Assignees

@RyanGrange RyanGrange

Labels
None yet
Projects
Kanban Board
  
Reviewer approved
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

.NetStandard and nuget
3 participants
@RyanGrange @aalhour @PatrykOlejniczak
You can’t perform that action at this time.