Skip to content

Create rail_fence_cipher.py #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Create rail_fence_cipher.py #2210

wants to merge 4 commits into from

Conversation

aakashdinkar
Copy link
Contributor

@aakashdinkar aakashdinkar commented Jul 17, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

cclauss
cclauss requested changes Jul 17, 2020
View reviewed changes
@TravisBuddy
Copy link

Hey @aakashdinkar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 8d2d8050-c85b-11ea-8ad2-cd0863c1f5b3

@cclauss
Copy link
Member

cclauss commented Jul 17, 2020

Please create a function for your algorithm of the form:

def rail_fence_encrypt(msg: str, key: str) --> str:
    """
    >>> rail_fence_encrypt("Hello!", "secret")
    'xdketlq'

These are type hints and a doctest as discussed in CONTRIBUTING.md.

@TravisBuddy
Copy link

Hey @aakashdinkar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 0f994fb0-c861-11ea-8ad2-cd0863c1f5b3

@TravisBuddy
Copy link

Hey @aakashdinkar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: b7133160-c862-11ea-8ad2-cd0863c1f5b3

@TravisBuddy
Copy link

Hey @aakashdinkar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d1479020-c86d-11ea-8ad2-cd0863c1f5b3

cclauss
cclauss requested changes Jul 18, 2020
View reviewed changes
ciphers/rail_fence_cipher.py
def rail_fence_encryption(string, key):
r, c = 0, 0
val = 0
for i in range(len(input_string)):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for i in range(len(input_string)):
for char in input_string:

ciphers/rail_fence_cipher.py
val = 0
elif r == 0:
val = 1
string_list[r][c] = input_string[i]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
string_list[r][c] = input_string[i]
string_list[r][c] = char

@stale
Copy link

stale bot commented Aug 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Aug 17, 2020
@stale
Copy link

stale bot commented Aug 24, 2020

Please reopen this issue once you commit the changes requested or make improvements on the code. Thank you for your contributions.

@stale stale bot closed this Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss requested changes

Assignees
No one assigned
Labels
stale Used to mark an issue or pull request stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aakashdinkar @TravisBuddy @cclauss