Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat: include logger plugin to the core export #1783
Merged
+28
−5
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR add
loggerplugin to the core export to be able to support ESM build for theloggerplugin. Issue was mentioned at vitejs/vite#334.This is for Vuex 3, so I'm keeping the individual bundle as is to avoid braking change. For Vuex 4, I'm planning to remove the logger bundle entirely.
Planning to follow up the PR with documentation update as well for the next release.