Skip to content

/ Javascript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added max non adjacent sum #197

Merged
merged 1 commit into from Jun 21, 2020
Merged

Added max non adjacent sum #197

merged 1 commit into from Jun 21, 2020

Conversation

@ruppysuppy
Copy link
Contributor

ruppysuppy commented Jun 21, 2020

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@ruppysuppy
Copy link
Contributor Author

ruppysuppy commented Jun 21, 2020

I am unable to rebase using git rebase HEAD~2 --onto master the commits due to some problem in HeapSort.js (I haven't touched it but it says that there are some changes, which I am unable to stage either using git add .)
@itsvinayak
itsvinayak requested changes Jun 21, 2020
View changes
Web-Programming/OpenWeatherMaps.js Outdated
@@ -0,0 +1,31 @@
const fetch = require('node-fetch')

This comment has been minimized.

Sign in to view
Copy link
@itsvinayak

itsvinayak Jun 21, 2020

Member

this file is already in this #196 PR, please remove this file from this PR so, no conflict arises

This comment has been minimized.

Sign in to view
Copy link
@ruppysuppy

ruppysuppy Jun 21, 2020

Author Contributor

I branched off from the web-programming branch by mistake and due to the HeapSort issue I am unable to rebase the branch on the master. What should I do?
@itsvinayak
update
Loading status checks…
d3547ee
@itsvinayak itsvinayak force-pushed the ruppysuppy:max-non-adj-sum branch from c9f9b4e to d3547ee Jun 21, 2020
@itsvinayak itsvinayak merged commit b2b1ad3 into TheAlgorithms:master Jun 21, 2020
2 checks passed
2 checks passed
build (14.x)
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsvinayak itsvinayak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ruppysuppy @itsvinayak
You can’t perform that action at this time.