Skip to content

/ Javascript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight modification in the for loop and cout #173

Open
wants to merge 1 commit into
base: master
from
Open

Slight modification in the for loop and cout #173

wants to merge 1 commit into from

Conversation

@Abhilashak2k
Copy link

Abhilashak2k commented May 18, 2020 •
edited

var len = theArray.length;
for (var n = 0; n < len; n++)

is minutely better than

for (var n = 0; n < theArray.length; n++)

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@Abhilashak2k
Slight modification in the for loop
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5b69353 
var len = theArray.length;
for (var n = 0; n < len; n++)

is minutely better than 

for (var n = 0; n < theArray.length; n++)
@itsvinayak
Copy link
Member

itsvinayak commented May 22, 2020

@Abhilashak2k some checks fail
code must follow standard pakage
thank you,
@access2content
access2content reviewed Aug 6, 2020
View changes
Search/LinearSearch.js
} else {
console.log('The element not found')
}
}

// Search “theArray” for the specified “key” value
function Search (theArray, key) {
for (var n = 0; n < theArray.length; n++) {
//store theArray.length in a variable so that .length function is not summoned in every iteration

This comment has been minimized.

Sign in to view
Copy link
@access2content

access2content Aug 6, 2020

".length" is not a function, it is a value. Therefore, a function is not "summoned" in every iteration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@access2content access2content

Assignees

@Abhilashak2k Abhilashak2k

Labels
failing npm standards
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Abhilashak2k @itsvinayak @access2content
You can’t perform that action at this time.