Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[very much a wip] pep 612 #9250

Closed
wants to merge 19 commits into from
Closed

[very much a wip] pep 612 #9250

wants to merge 19 commits into from

Conversation

@hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Aug 3, 2020 •
edited

Tracking issue for PEP 612: #8645
hauntsaninja added 19 commits Aug 1, 2020
mypy: [minor] use get_type_vars
6da27da
semanal: make some typevar functions reusable for paramspec
e7d7726
tests: add fixture for mypy_extensions.ParamSpec
914866d
semanal: add test for ParamSpec
2dc2cfe
semanal: process ParamSpecs
1afd84b
nodes: add node for ParamSpec
3c2c655
checkexpr: add paramspec visitor to ExpressionChecker
5f79199 
This allows checkexpr to recognise the call to
typing.ParamSpec as producing a special form
literals: [minor] add a useless visitor method
69d4ca7
types: add TypeVarLikeDef, ParamSpecDef
ffb3f9b
tvar_scope: support ParamSpec
b7309ea
semanal: disallow paramspec in generic class for now
375a6a3
tests: [incomplete] add the basic tests from PEP 612
333d337
types: [causes unsolved type errors] change type of CallableType.vari…
72661e1 
…ables
applytype: use zip, closure
3f72d8f
anal: generalise TypeVarList, TypeVariableQuery
fedbd57
typeanal: error for unbound ParamSpec
51bba7e
types: add ParamSpecType
b5a566c
expandtype: fix type errors
1ad8b65
typeanal: error for invalid location for ParamSpec
c0f6f26
@hauntsaninja hauntsaninja mentioned this pull request Aug 3, 2020
Open
@JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Aug 7, 2020

Thanks for working on this! This addresses a common user pain point.

I haven't had time to look at this in detail, but here are some general thoughts. The implementation doesn't need to be complete before merging -- maintaining a big PR over time gets tedious. Tests need to pass, of course. One option would be to add a command-line flag for enabling experimental features. Another option would be to document the feature as experimental until it's fully implemented and enable it always (this is what we've done previously).

@gvanrossum gvanrossum mentioned this pull request Aug 15, 2020
Closed
@hauntsaninja hauntsaninja mentioned this pull request Aug 22, 2020
Merged
@hauntsaninja hauntsaninja mentioned this pull request Sep 6, 2020
Merged
JukkaL pushed a commit that referenced this issue Sep 8, 2020
@hauntsaninja
pep612: more semantic analysis for paramspec (#9422)
ec76cca 
Linking #8645

Like #9339, much of this is in #9250. However, this PR is a little less self 
contained, in that it causes several future TODOs.

A lot of the changes here are necessitated by changing the type of 
CallableType.variables to Sequence[TypeVarLikeDef]. This is nice, because 
it informs me where I need to make changes in the future / integrates a little 
bit better with existing type var stuff.
@erictraut erictraut mentioned this pull request Jun 13, 2021
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@hauntsaninja @JukkaL