Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDOC: add additional numba example #35550
Open
Comments
|
I think I took that from the docs (perhaps the whatsnew?)
…On Tue, Aug 4, 2020 at 12:37 PM Ray Bell ***@***.***> wrote:
Location of the documentation
https://pandas.pydata.org/pandas-docs/stable/user_guide/enhancingperf.html#using-numba
Documentation problem
Provide a simpler copy-paste example.
Suggested fix for documentation
@TomAugspurger <https://github.com/TomAugspurger> has a nice example of
using numba to speed up a rolling.apply() operation here
https://github.com/TomAugspurger/acon-2020-pandas/blob/master/Numba%20Acceleration.ipynb
Could this or a variant of this be added to the docs? Perhaps to show that
you don't need to do import numba but can do engine='numba'
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35550>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOISTDJKL6Y3SJRS556DR7BBM3ANCNFSM4PUUKJHQ>
.
|
|
May I take up this issue? |
|
sir, can I work on this |
|
take |
|
I think just linking from one to the other is fine.
…On Mon, Aug 17, 2020 at 6:04 PM Erfan Nariman ***@***.***> wrote:
@TomAugspurger <https://github.com/TomAugspurger> @simonjayhawkins
<https://github.com/simonjayhawkins> Makes sense to add this as an
example in the Numba part of enhancingperf.rst, but the example in
computation.rst is pretty extensive, it just needs an example. Should I
add the example to computation.rst in this case and mention to it in the
Numba part? I can also copy the text from computation.rst and add an
example for it in enhancing.rst, but that seemse redundant.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35550 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIQHSDANHJCH6XSU6LLSBGZPZANCNFSM4PUUKJHQ>
.
|
|
Didnt want to remove comment, wanted to edit. Thanks for reply @TomAugspurger |
|
@TomAugspurger kindly tell I could contribute in any way, as I am new to open source |
|
We have a contributing guide at
https://pandas.pydata.org/docs/development/contributing.html. It recommends
how to find a good first issue.
…On Mon, Aug 17, 2020 at 8:29 PM Vaibhav arora ***@***.***> wrote:
@TomAugspurger <https://github.com/TomAugspurger> kindly tell I could
contribute in any way, as I am new to open source
thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35550 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIRHBZWITTGA4UIUNRTSBHKPRANCNFSM4PUUKJHQ>
.
|
|
Thanks alot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Location of the documentation
https://pandas.pydata.org/pandas-docs/stable/user_guide/enhancingperf.html#using-numba
Documentation problem
Provide a simpler copy-paste example.
Suggested fix for documentation
@TomAugspurger has a nice example of using numba to speed up a
rolling.apply()operation here https://github.com/TomAugspurger/acon-2020-pandas/blob/master/Numba%20Acceleration.ipynbCould this or a variant of this be added to the docs? Perhaps to show that you don't need to do
import numbabut can doengine='numba'