Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upQuick sort algorithms #2306
Open
Quick sort algorithms #2306
Conversation
sorts/quick_sort_3_partition.py
Outdated
3 : elements greater than the pivot | ||
For doctests run following command: | ||
python -m doctest -v quick_sort_3partition.py |
This comment has been minimized.
This comment has been minimized.
sorts/quick_sort_3_partition.py
Outdated
For doctests run following command: | ||
python -m doctest -v quick_sort_3partition.py | ||
or |
This comment has been minimized.
This comment has been minimized.
sorts/quick_sort_3_partition.py
Outdated
""" | ||
|
||
|
||
def quick_sort_3partition(my_list: list, left: int = 0, right: int = None) -> list: |
This comment has been minimized.
This comment has been minimized.
sorts/quick_sort_3_partition.py
Outdated
sorting[a], sorting[i] = sorting[i], sorting[a] | ||
a += 1 | ||
return my_list | ||
i: int = left |
This comment has been minimized.
This comment has been minimized.
cclauss
Aug 14, 2020
•
Member
left is already declared to be an int so type checkers are smart enough to know that i is also an int.
Updated with your comments. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
BriseBalloches commentedAug 13, 2020
Describe your change:
Improve the two quick sort algorithms (simple and 3 partitions).
Added type hints, docstrings, doctests, better implementation when possible.
Since the two files concern the same algorithm (one being a variation of the other), i decided to create one PR.
Checklist:
Fixes: #{$ISSUE_NO}
.