Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick sort algorithms #2306

Open
wants to merge 4 commits into
base: master
from

Conversation

@BriseBalloches
Copy link
Contributor

BriseBalloches commented Aug 13, 2020

Describe your change:

Improve the two quick sort algorithms (simple and 3 partitions).
Added type hints, docstrings, doctests, better implementation when possible.
Since the two files concern the same algorithm (one being a variation of the other), i decided to create one PR.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
3 : elements greater than the pivot
For doctests run following command:
python -m doctest -v quick_sort_3partition.py

This comment has been minimized.

@cclauss

cclauss Aug 14, 2020

Member
Suggested change
python -m doctest -v quick_sort_3partition.py
For doctests run following command:
python -m doctest -v quick_sort_3partition.py
or

This comment has been minimized.

@cclauss

cclauss Aug 14, 2020

Member
Suggested change
or
"""


def quick_sort_3partition(my_list: list, left: int = 0, right: int = None) -> list:

This comment has been minimized.

@cclauss

cclauss Aug 14, 2020

Member

You cannot declare a variable to be an int and then assign None to it.

sorting[a], sorting[i] = sorting[i], sorting[a]
a += 1
return my_list
i: int = left

This comment has been minimized.

@cclauss

cclauss Aug 14, 2020

Member

left is already declared to be an int so type checkers are smart enough to know that i is also an int.

@BriseBalloches
Copy link
Contributor Author

BriseBalloches commented Aug 14, 2020

Updated with your comments. Thanks.

@BriseBalloches BriseBalloches requested a review from cclauss Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.