Skip to content

/ arangodb

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix 3.7/bts 169 #12492

Merged
merged 6 commits into from Aug 28, 2020
Merged

Bug fix 3.7/bts 169 #12492

merged 6 commits into from Aug 28, 2020

Conversation

@jsteemann
Copy link
Contributor

@jsteemann jsteemann commented Aug 21, 2020

Scope & Purpose

Fix BTS-169: Cost estimation for LIMIT nodes was wrong
https://arangodb.atlassian.net/browse/BTS-169
Backport of #12491

This is a cosmetic change, but should not have any effect on execution plans other than fixing the number of estimated items.

  • 💩 Bugfix
  • 📖 CHANGELOG entry made
  • 💪 The behavior in this PR was manually tested
  • 💻 The behavior change can be verified via automatic tests

Backports:

  • No backports required
  • Backports required for: 3.7

Related Information

Testing & Verification

  • This PR adds tests that were used to verify all changes:
    • Added Regression Tests
    • Added new C++ Unit Tests
    • Added new integration tests
    • Added new resilience tests (only if the feature is impacted by failovers)

http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/11582/
jsteemann added 2 commits Aug 20, 2020
@jsteemann
fix number-of-documents estimation for LimitNode
c8b9ecf
@jsteemann
fix cost estimation for LIMIT nodes
f83c311
@jsteemann jsteemann added this to the 3.7 milestone Aug 21, 2020
@jsteemann jsteemann requested a review from gnusi Aug 21, 2020
jsteemann added 2 commits Aug 25, 2020
@jsteemann
Merge branch '3.7' of github.com:arangodb/arangodb into bug-fix-3.7/b…
b6c8d7f 
…ts-169
@jsteemann
fixed cost estimated, add cost tests
e4d9241
@jsteemann
Copy link
Contributor Author

@jsteemann jsteemann commented Aug 25, 2020

http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/11629/
@gnusi
gnusi approved these changes Aug 25, 2020
View changes
Copy link
Contributor

@gnusi gnusi left a comment

LGTM
@jsteemann
Copy link
Contributor Author

@jsteemann jsteemann commented Aug 25, 2020

http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/11631/
@jsteemann
Copy link
Contributor Author

@jsteemann jsteemann commented Aug 25, 2020

Tests blue
KVS85 added 2 commits Aug 28, 2020
@KVS85
Update CHANGELOG
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
7a0fde8
@KVS85
Merge branch '3.7' into bug-fix-3.7/bts-169
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
62dbaf4
@KVS85 KVS85 merged commit 0b1dd33 into 3.7 Aug 28, 2020
@KVS85 KVS85 deleted the bug-fix-3.7/bts-169 branch Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnusi gnusi

Assignees

@jsteemann jsteemann

Labels
9 Ready to Merge
Projects
None yet
Milestone
3.7
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@jsteemann @gnusi @KVS85
You can’t perform that action at this time.