Skip to content

/ arangodb

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable attempts to create smart satellite graphs/collections #12523

Merged
merged 4 commits into from Aug 26, 2020
Merged

disable attempts to create smart satellite graphs/collections #12523

merged 4 commits into from Aug 26, 2020

Conversation

@jsteemann
Copy link
Contributor

@jsteemann jsteemann commented Aug 25, 2020

Scope & Purpose

Disable attempts to create smart satellite graphs/collections, as this combination does not make sense.
Any such attempts will now result in an HTTP 400 ("Bad request") error to be returned.

  • 💩 Bugfix
  • 🍕 New feature
  • 🔨 Refactoring
  • 📖 CHANGELOG entry made
  • 💪 The behavior in this PR was manually tested
  • 💻 The behavior change can be verified via automatic tests

Enterprise PR: arangodb/enterprise#537

Backports:

  • No backports required
  • Backports required for: 3.7

Testing & Verification

  • This change is a trivial rework / code cleanup without any test coverage.
  • This change is already covered by existing tests, such as (please describe tests).
  • This PR adds tests that were used to verify all changes:
    • Added new integration tests (i.e. in shell_server, shell_client)

http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/11645/
@jsteemann
disable attempts to create smart satellite graphs/collections
90d95f7
@jsteemann jsteemann added this to the devel milestone Aug 25, 2020
@jsteemann jsteemann requested review from hkernbach and mchacki Aug 25, 2020
@jsteemann
updated CHANGELOG
c31e13b
@hkernbach
hkernbach approved these changes Aug 25, 2020
View changes
@jsteemann
Copy link
Contributor Author

@jsteemann jsteemann commented Aug 25, 2020

Restarted Jenkins run after adding more tests:
http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/11650/
@jsteemann
Copy link
Contributor Author

@jsteemann jsteemann commented Aug 25, 2020

Tests blue except unrelated known issue.
@jsteemann
Merge branch 'devel' into bug-fix/disable-smart-satellite-creation
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
e7eef8a
@joerg84
joerg84 reviewed Aug 25, 2020
View changes
arangod/VocBase/Methods/Collections.cpp Outdated Show resolved Hide resolved
@jsteemann
remove #ifdef
c955945
@jsteemann
Copy link
Contributor Author

@jsteemann jsteemann commented Aug 25, 2020

http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/11654/
@jsteemann
Copy link
Contributor Author

@jsteemann jsteemann commented Aug 26, 2020

Tests blue
@jsteemann jsteemann merged commit 90720db into devel Aug 26, 2020
@jsteemann jsteemann deleted the bug-fix/disable-smart-satellite-creation branch Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerg84 joerg84

@hkernbach hkernbach

@mchacki mchacki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
devel
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@jsteemann @hkernbach @joerg84
You can’t perform that action at this time.