check that instance init occurred without errors #731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsora
added
type: imperfection
silvanocerza
added
conclusion: invalid
|
#708 has been solved, closing this since it's not relevant anymore. Also the internal instance handling has changed a ton. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix. Fixes panic: runtime error: invalid memory address or nil pointer dereference (version 0.10.0) #708
Check for init errors when creating an instance
What is the current behavior?
panic: runtime error: invalid memory address or nil pointer dereference (version 0.10.0) #708
When initialising the instance, the error response is not checked. This causes a nil pointer dereference when trying to access the library.
What is the new behavior?
Checks for error when initialising the instance and exit the program with an error code and message.
Does this PR introduce a breaking change?
No
Other information:
See how to contribute