Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix infinite recursion issue in SERCOM::startTransmissionWIRE #535
Conversation
* If a significant hardware issue is struck startTransmissionWIRE calls itself to restart sending the address+r/w byte. The stack can be blown very quickly in the event of a prolonged hardware issue that warrants transmission restarts. A restart limit has been added (currently set at 5) to fix this issue. * This fixes issue #476 and it builds on work by @jrowberg in which a timeout was added addressing issue #439. * Some code simplification and tidying has followed from #439 and #476 being resolved.
* TwoWire::endTransmission layout changed to be more inline with TwoWire::requestFrom because they are essentially functioning in a similar way. * Sending of stop condition moved to within block of successful start. Apon successful start but unsuccessful read/write, stop condition is also sent - regardless of whether stop has been requested at that time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
If a significant hardware issue is struck startTransmissionWIRE
calls itself to restart sending the address+r/w byte. The stack
can be blown very quickly in the event of a prolonged hardware
issue that warrants transmission restarts. A restart limit has
been added (currently set at 5) to fix this issue.
This fixes issue #476 and it builds on work by @jrowberg in which
a timeout was added addressing issue #439.
Some code simplification and tidying has followed from #439 and #476
being resolved.