Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upcomposer archive crashes on bad line in .gitignore file #7440
Comments
Not sure if this is a bug in Composer or |
I've had a look at this issue and my conclusion would be that it is a borked The test case graciously provided by @mborne shows that the issue is still reproducible on the current The only adjustment to As for Composer, a simple solution could be to prefix the filter |
Hello,
I have a full
satis build
generation that is interrupted with apreg_match(): Compilation failed: missing ) at offset 24
whencomposer archive
is invoked on a specific project tag.It seams that
composer archive
crashes in archive generation when.gitignore
contains strange lines.For example,
/${ctx
will lead to the following invocation in https://github.com/composer/composer/blob/1.6.5/src/Composer/Package/Archiver/BaseExcludeFilter.php#L62 :Would it be possible to validate
$pattern
and ignore invalid ones?PS :
--skip-errors