Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upconnected-react-router-6-fix #71
Conversation
vercel
bot
commented
Dec 19, 2018
This pull request is automatically deployed with Now. |
Hi @vipinlahoti Thanks for the PR. I'll take some time to review this, update the written tutorial surrounding this boilerplate and merge. Could yo resolve the conflicting Thanks for your PR |
Hi @notrab conflicts are resolved. |
@notrab this boilerplate is really of smaller size and the only available, I think you must expand this app connecting with backend or some kind of storage to make it full stack boilerplate with CRUD operations. |
dcsan
commented
Jan 25, 2019
@vipinlahoti did you take any further steps to connect it with Axios? I am using this bolierplate as a basis to learn me some redux and going through tutorials right now to start connecting it to a backend... |
vercel
bot
commented
Jan 25, 2019
Deployment failed with the following error:
|
vercel
bot
commented
Jan 25, 2019
Deployment failed with the following error:
|
@dcsan not getting much time on this, but taking sometime to enhance and will connect it with Axios. |
vercel
bot
commented
Jan 26, 2019
Deployment failed with the following error:
|
dcsan
commented
Jan 27, 2019
hi! I get an error trying to start this up:
checking the package.json we have:
so, magic all the way down
also wondering about your directory structure, aren't reducers usually kept together etc? although your example now is quite simple keeping all the Todo related stuff together in one directory. |
dcsan
commented
Jan 27, 2019
OK i think the problem is because folders and files are inconsistent in upper/lower case. maybe you're running on a different file system. for me on a mac - which is usually NOT case sensitive it was throwing these errors, maybe some magic inside react-scripts. the diff below gets things to run, but a better fix would be to rename all folders consistently upper or lower. eg I noticed your just changing the case of things is always a problem on the mac with git since the filesystem itself isn't case sensitive...
➜ crapr git:(connected-react-router) ✗ git diff
diff --git a/src/containers/app/index.js b/src/containers/app/index.js
index c100436..85faa2b 100644
--- a/src/containers/app/index.js
+++ b/src/containers/app/index.js
@@ -7,8 +7,8 @@ import { Helmet } from 'react-helmet';
import { Switch, Route } from 'react-router-dom';
import Header from 'components/Header';
-import Home from 'containers/Home';
-import About from 'containers/About';
+import Home from 'containers/home';
+import About from 'containers/about';
import Todo from 'containers/Todo';
const App = () => (
diff --git a/src/index.js b/src/index.js
index f0af05b..03c3017 100644
--- a/src/index.js
+++ b/src/index.js
@@ -6,7 +6,7 @@ import { IntlProvider } from 'react-intl';
import * as serviceWorker from 'utils/serviceWorker';
import history from 'utils/history';
-import App from 'containers/App';
+import App from 'containers/app';
import store from './store';
import messages from './i18n-en-us.json';
diff --git a/src/reducer.js b/src/reducer.js
index 9060c30..cec1f4c 100644
--- a/src/reducer.js
+++ b/src/reducer.js
@@ -6,7 +6,7 @@ import { combineReducers } from 'redux';
import { connectRouter } from 'connected-react-router';
import history from 'utils/history';
-import countReducer from 'containers/Home/reducer';
+import countReducer from 'containers/home/reducer';
import todoReducer from 'containers/Todo/reducer';
export default combineReducers({ |
This boilerplate was created for the tutorial I wrote over on Medium which follows the "ducks" approach. I'll have to update the Medium tutorial to reflect any changes to the above router changes. |
polymer940c
commented
Feb 20, 2019
change the |
cristian-sima
commented
Feb 20, 2019
Any idea when this will be solved? |
cwagner22
commented
Jan 21, 2020
Any update on this? |
vipinlahoti commentedDec 19, 2018
connected-react-router-v6 with react-redux-6