Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Reorganize git commands #263
Conversation
d8252ed
to
e764e1c
|
||
Reverts python/cpython#111. | ||
Reason: This commit broke the buildbot. | ||
|
The above steps can be executed against any branch you wish to, just replace master | ||
with an appropriate branch name. | ||
|
||
|
ezio-melotti
Sep 6, 2017
Author
Member
All the stuff in this chunk either got added to the bootcamp or it was already there
@@ -454,34 +336,19 @@ Developers can apply labels to GitHub pull requests). | |||
.. _cherry_picker.py: https://github.com/python/core-workflow/tree/master/cherry_picker | |||
|
|||
|
|||
.. _forking: | |||
|
|||
Forking repository |
|
||
Maintaining a repository |
ezio-melotti
Sep 6, 2017
Author
Member
After asking around during the sprint, the consensus was to remove this section.
Looks great @ezio-melotti. There's a few small items and then it's ready to merge. Thanks |
|
||
origin git@github.com:<your-username>/devguide.git (fetch) | ||
origin git@github.com:<your-username>/devguide.git (push) | ||
upstream git@github.com:python/devguide.git (fetch) |
willingc
Sep 6, 2017
Collaborator
Since this doc will often be used by contributors that do not have push privileges for CPython, the upstream remote should point to https://github.com/python/cpython
in the doc here.
Perhaps a note for committers that they should use what you have here for upstream.
ezio-melotti
Sep 7, 2017
Author
Member
AFAICT, with this URL, they still should be able to fetch. If they try to push they will get an error because they don't have privileges, but that's OK since they are not supposed to push on upstream anyway. Unless I'm missing something, this URL should be fine for both contributors and core devs.
Mariatta
Sep 7, 2017
Member
Thanks @willingc and @ezio-melotti. I'm thinking it's fine to leave the upstream
using SSH url.
For contributors, they would have to configure SSH key anyway.
``git push``, or ``git fetch``. | ||
|
||
``git push``, or ``git fetch``. On Windows, you should also | ||
:ref:`enable autocrlf <autocrlf>`. |
git clone https://github.com/python/cpython | ||
In order to get a copy of the source code you should first :ref:`fork the | ||
Python repository on GitHub <fork-cpython>` and then :ref:`create a local | ||
clone of your private fork and configure the remotes <clone-your-fork>`. |
willingc
Sep 6, 2017
Collaborator
private I know what you are trying to say here but the fork is public. I think it is better to use ...clone of your fork and configure...
ezio-melotti
Sep 6, 2017
Author
Member
"Personal" is probably the word I was looking for, but "your fork" is clear enough without additional qualifiers.
Thanks @ezio-melotti. |
2905cf3
to
a3c6133
Thanks for the reviews! |
Way to go @ezio-melotti on reorganizing |
This is part of #120. The goal of this PR is to reorganize the git commands, that are currently scattered around a few pages.
The steps are:
The end result will be:
See also #262.