@timoschilling Was this causing an issue for you somewhere? I was always kind of a fan of this feature as a smart default 😃

👍 becuase it's now more predictable. In other cases, you are always can add more names to the settings array.

The old one is sometimes confusing. I share @dmitry's opinion. The new List ist more explicit.

I think about to rename display_name to active_admin_display_name or something like that. To avoid conflicts and to decelerate for what the method is on the model.

I'm waiting with the merge for more discussion.

Alright, fair enough. What if instead of changing display_name to active_admin_display_name, we add a display_name_method DSL method to resources and fall back to calling display_name on models? Something like:

ActiveAdmin.register User do
  # ...
  display_name_method :name
  # ...
end

I think it's might be better to do this than mixing ActiveAdmin-related presentation logic into models. Thoughts?

(This is probably beyond the scope of this PR though, and something I would be happy to tackle)

@mattvague I like the idea of not mixing ActiveAdmin-related presentation logic into models! But what is with Models which are not registered in ActiveAdmin? How should they be configured?

@timoschilling That's a good question. Would it make sense to just rely on #display_name and any other methods registered in display_name_methods for these models?

If people want AA-specific display names for models that they don't want in the menu they would have 2 options:

1. Register something like active_admin_display_name in display_name_methods themselves
2. Register the resource, specify display_name_method, and hide the resource from the menu (menu false)

@timoschilling Thoughts?

I really don't think this is something that should change, when we haven't even gotten out 1.0.0. People have relied on this behavior for many years now, and there's no good way to warn them that it's changed. If we're going to change this, it should wait until 2.0.

@timoschilling we are moving forward with breaking changes for master (for a v2). Are you able to update the conflicts so we can review for merging in?