Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document http.OutgoingMessage #33847

Open
rexagod opened this issue Jun 11, 2020 · 16 comments
Open

document http.OutgoingMessage #33847

rexagod opened this issue Jun 11, 2020 · 16 comments

Comments

@rexagod
Copy link
Contributor

@rexagod rexagod commented Jun 11, 2020

AFAIK There's no documentation available for http.OutgoingMessage. Any new contributor willing to work on this can refer http.IncomingMessage for some inspiration.

@rexagod rexagod added the doc label Jun 11, 2020
@rexagod rexagod changed the title document http.OutgoingMessage document http.OutgoingMessage [good first issue!] Jun 11, 2020
@ronag ronag changed the title document http.OutgoingMessage [good first issue!] document http.OutgoingMessage Jun 13, 2020
@matthenschke
Copy link

@matthenschke matthenschke commented Jun 14, 2020

I'll work on it!

@matthenschke
Copy link

@matthenschke matthenschke commented Jun 14, 2020

Do you know where I can find the js code for OutgoingMessage, and are there any dependencies I should look at before attempting to add this documentation?

@rexagod
Copy link
Contributor Author

@rexagod rexagod commented Jun 15, 2020

You'll find the code in lib/_http_outgoing.js. There are no dependencies to worry about. :)

@finhaa
Copy link

@finhaa finhaa commented Jul 24, 2020

Hey! I would like to contribute with this if there is no one else already contributing.

@rexagod
Copy link
Contributor Author

@rexagod rexagod commented Jul 24, 2020

@matthenschke Are you working on this?

@finhaa In the meantime you can take a look at nodetodo to find something interesting to work on! :)

@matthenschke
Copy link

@matthenschke matthenschke commented Jul 24, 2020

The task is all yours @finhaa ! :)

@balrajsingh9
Copy link

@balrajsingh9 balrajsingh9 commented Jul 28, 2020

Hey I would like to take this up if available ✌️

@finhaa
Copy link

@finhaa finhaa commented Jul 30, 2020

Hey @rexagod, I won't be able to work in that task on this week. Sorry about that.

@balrajsingh9 You can take this!

@balrajsingh9
Copy link

@balrajsingh9 balrajsingh9 commented Jul 31, 2020

I have set up the workspace, but I need a kickstart. Can someone please help me out here?

I see a PR already opened referencing this issue, may I go ahead and borrow what's already documented from there?

@rexagod
Copy link
Contributor Author

@rexagod rexagod commented Jul 31, 2020

@balrajsingh9 You are free to look around and include in your PR whatever seems fit for this issue, I think @matthenschke won't mind, although you can include their commits in your PR in case you are entirely basing your work off of theirs, that way they can get credit for their work. :)

@jamesurobertson
Copy link

@jamesurobertson jamesurobertson commented Aug 21, 2020

I can work on this if nobody else is still. Are you working on it still @balrajsingh9 ?

@balrajsingh9
Copy link

@balrajsingh9 balrajsingh9 commented Aug 21, 2020

@jamesurobertson I was busy in moving abroad and finishing up with my current job. Please give me a week(max). If I don't finish this, I'll ping here and you may pick up.

@Hamza-324
Copy link

@Hamza-324 Hamza-324 commented Aug 26, 2020

Hey guys, has this been done on can I work on this?

@jamesurobertson
Copy link

@jamesurobertson jamesurobertson commented Aug 26, 2020

@Hamza-324 I was giving @balrajsingh9 a few more days per his last response to work on it before I was going to take care of it.

Any updates @balrajsingh9 ?

@balrajsingh9
Copy link

@balrajsingh9 balrajsingh9 commented Aug 26, 2020

@jamesurobertson Please go ahead. I was almost done, but settling in a new country is taking longer than it should.

Please take this up. 👍

@Hamza-324
Copy link

@Hamza-324 Hamza-324 commented Aug 27, 2020

Okay @jamesurobertson, Best of luck with this (Y)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.