Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #4151: Report a somewhat helpful message for back-end exceptions. #4179
+27
−0
Conversation
This implements exactly the same last resort mechanism as the JVM for back-end crashes. In particular, it applies for string literals that are too long to be serialized (in JVM bytecode or in SJSIR). Arguably, this should be caught earlier as a nice front-end compile error, but that is not a job for Scala.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sjrd commentedSep 7, 2020
This implements exactly the same last resort mechanism as the JVM for back-end crashes. In particular, it applies for string literals that are too long to be serialized (in JVM bytecode or in SJSIR).
Arguably, this should be caught earlier as a nice front-end compile error, but that is not a job for Scala.js.